From the Annals of Dubious Achievement
July 13th, 2009

It is I who wrote RichardIsAFuckingIdiotControl, voted the "best comment in source code … ever encountered" in this StackOverflow question. I didn't submit it, nor do I know the person that did. (I came across it on reddit, or something. I don't have the will or personal bandwidth to participate in something like StackOverflow.) This happened at a former employer.

I am not sure that I am proud of this. Actually I'm pretty sure that I'm not proud of it. But I'll explain what the deal was for the record anyway. I am also not sure that this deserves the "accolades" that it received. After all it's not technically a comment (although it contains some doozies) and I would never have chosen pure vitriol over, say, something from Ritchie's Odd Comments and Strange Doings in Unix.

Obviously what sets this apart from other snippets in the genre is the over-the-top hatred of a very specific colleague. So let me tell you a little about Richard.

First, his name wasn't Richard. Whoever submitted the sample was wise enough to change that (thanks, guy). I didn't even use his given name in the original source, although it was a moniker that most people would have understood. "Richard" was no longer employed by the company when I wrote this. He had recently been fired for repeatedly showing up in the early to mid-afternoon drunk and coked out of his mind (I guess nobody told him that we real programmers show up on time and drink at our desks).

Richard was a recent college grad with roughly a 1.8 GPA from a decent-but-not-prestigious CS program. Miraculously (if you're Richard), someone decided he was a "cultural fit" and therefore deserved $70K per year. For readers who have only ever been exposed to polite society, it is important to note that this is standard practice in the financial industry and is considered "normal." Around this time, I had gotten a little bent out of shape about hiring for various reasons that I won't go into, and I was the asshole. Go figure.

Personally, there is only one word that describes the kid. That word is broseph. If I were to call him a violent, drug-addled menace, it would not be hyperbole. Let me say it again, "cultural fit."

After Richard's exit, I had to take over his code. I wound up rewriting almost all of it from scratch, and this class was serving as a blast shield around the volatile remains of what I could salvage. Honestly, at this point I was bored to tears, and a lot of what I did was probably total crap. If there's any justice, right now someone's writing a profanity-laden class with my name all over it.

But anyway, let's go over the code. I'll add some color, where I can remember what was going on.

// The main problem is the BindCompany() method,
// which he hoped would be able to do everything. I hope he dies.

I am firmly opposed to the death penalty, but if a piano fell on his head I would be sincerely happy. (And again, for some reason I'm the asshole.)

public void BindCompany(int companyId) { }

// snip

private void MakeSureNobodyAccidentallyGetsBittenByRichardsStupidity()
    // Make sure nobody is actually using that fucking bindcompany method
    MethodInfo m = this.GetType().GetMethod("BindCompany", BindingFlags.DeclaredOnly |
    BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic);
    if (m != null)
        throw new RichardIsAFuckingIdiotException("No!! Don't use the fucking BindCompany method!!!");
    // P.S. this method is a joke ... the rest of the class is fucking serious

There was some deeply-entrenched reason why I could not change the definition of the BindCompany method. It had to be there, but the code paths that called it were all fundamentally flawed, or something like that. I decided to be funny and use reflection to raise an exception if anyone happened to redefine with an implementation of it in a derived class.

/// <summary>
/// This returns true if this control is supposed to be doing anything
/// at all for this request. Richard thought it was a good idea to load
/// the entire website during every request and have things turn themselves
/// off. He also thought bandanas and aviator sunglasses were "fuckin'
/// gnarly, dude."
/// </summary>
protected bool IsThisTheRightPageImNotSureBecauseRichardIsDumb()
    return Request.QueryString["Section"] == this.MenuItemKey;

One of the really crazy things about this application was that for every web request, it would actually load several hundred control classes and call methods on them. Maybe two or three of these would actually be necessary. They would all determine (based on the URL, I think) if they were supposed to be drawing anything. It would have been much easier to, god I don't know, just call the methods that were necessary to draw each page. I still have nightmares about this ridiculous contraption every now and then.

I guess the StackOverflow snippet doesn't capture this, but the best thing about Richard's code was that he loved property getters and setters. No, wait, that's not quite right. Lots of people love getters and setters, but Richard seemed to be in love with getters and setters. So much so that about 70% of his logic took place in them. More than once I deleted code that looked like this:

foo.x = foo.x;

Only to break entire pages, because the side effects of that assignment were doing everything. Anyway, I hope you can all see where I was coming from now.

RSS | Atom | Copyright © 2004-2017 Dan McKinley. At no point has the writing here constituted the opinions of my employer(s).